Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to vs/base disposables #5106

Merged
merged 7 commits into from
Jul 15, 2024
Merged

Move to vs/base disposables #5106

merged 7 commits into from
Jul 15, 2024

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Jul 14, 2024

This is mainly just a clean up.

  • disposeArray() -> dispose()
  • getDisposeArrayDisposable() -> combinedDisposable()
  • Disposable.isDisposed -> Disposable._store.isDisposed

@Tyriar Tyriar added this to the 6.0.0 milestone Jul 14, 2024
@Tyriar Tyriar self-assigned this Jul 14, 2024
@Tyriar Tyriar marked this pull request as ready for review July 15, 2024 17:11
@Tyriar Tyriar merged commit cb3bd46 into xtermjs:master Jul 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant